aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/mscc
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2019-02-08 23:08:39 -0800
committerDavid S. Miller <davem@davemloft.net>2019-02-08 23:08:39 -0800
commit0abc676e64e269c59de8dbb8305640f6323f0d02 (patch)
tree808921512fc50f32d877755b2fc6a3f3da1a3a16 /drivers/net/ethernet/mscc
parentethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create (diff)
parentnet: marvell: mvpp2: fix AN restart (diff)
downloadlinux-dev-0abc676e64e269c59de8dbb8305640f6323f0d02.tar.xz
linux-dev-0abc676e64e269c59de8dbb8305640f6323f0d02.zip
Merge branch 'mvpp2-phylink-fixes'
Russell King says: ==================== mvpp2 phylink fixes Having spent a while debugging issues with Sven Auhagen, it appears that the mvpp2 network driver's phylink support isn't quite correct. This series fixes that up, but, despite being tested locally, by Sven, and by Antoine, I would prefer it to be applied to net-next so that there is time for more people to test before it hits -rc or stable backports. The symptoms were that although PHYs would come up, the GMAC never reported that the link was up, or in some cases it did report link up but packets would not flow. Various approaches were tried to work around that, such as switching to in-band negotiation from PHY mode, but ultimately the problem was in the way mvpp2 was being programmed. This series addresses that by, essentially, making mvpp2 follow the same implementation pattern as mvneta: we configure the GMAC in three stages: 1) the PHY interface mode 2) the negotiation advert 3) the negotiation style Another issue is that mvpp2 was always taking the link down each time its mac_config method was called: this is disruptive when the link is already up, and we're just updating settings such as flow control. There are some circumstances where we make the call despite there being no changes (eg, when phylink is polling a GPIO or using a custom link state function.) This series depends on two previous patches already sent for net-next: net: marvell: mvpp2: fix lack of link interrupts net: marvell: mvpp2: use phy_interface_mode_is_8023z() helper There is one last patch which deals with link status interrupts, which I'll send separately because I think there's other considerations, but that should not hold up this series of patches. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mscc')
0 files changed, 0 insertions, 0 deletions