diff options
| author |   Lv Yunlong <lyl2019@mail.ustc.edu.cn> | 2021-03-29 05:36:48 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-03-29 13:41:17 -0700 |
| commit | 63415767a2446136372e777cde5bb351f21ec21d (patch) | |
| tree | d2a57572fb66cf6e79aa83e02af97896bbea2182 /drivers/net/ethernet/myricom/myri10ge/myri10ge.c | |
| parent | MAINTAINERS: Add entry for Qualcomm IPC Router (QRTR) driver (diff) | |
| download | linux-dev-63415767a2446136372e777cde5bb351f21ec21d.tar.xz linux-dev-63415767a2446136372e777cde5bb351f21ec21d.zip | |
ethernet: myri10ge: Fix a use after free in myri10ge_sw_tso
In myri10ge_sw_tso, the skb_list_walk_safe macro will set
(curr) = (segs) and (next) = (curr)->next. If status!=0 is true,
the memory pointed by curr and segs will be free by dev_kfree_skb_any(curr).
But later, the segs is used by segs = segs->next and causes a uaf.
As (next) = (curr)->next, my patch replaces seg->next to next.
Fixes: 536577f36ff7a ("net: myri10ge: use skb_list_walk_safe helper for gso segments")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/myricom/myri10ge/myri10ge.c')
| -rw-r--r-- | drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index 1634ca6d4a8f..c84c8bf2bc20 100644 --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c @@ -2897,7 +2897,7 @@ static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb, dev_kfree_skb_any(curr); if (segs != NULL) { curr = segs; - segs = segs->next; + segs = next; curr->next = NULL; dev_kfree_skb_any(segs); } |