diff options
| author |   Jakub Kicinski <jakub.kicinski@netronome.com> | 2018-11-06 17:07:30 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-11-07 11:45:22 -0800 |
| commit | e50bfdf74d5f81c81f7a00498aa7fd1cba53b65b (patch) | |
| tree | 3fef23b90241a31d4133e77a7cc33a74a2d7d48b /drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | |
| parent | nfp: flower: add ipv6 set flow label and hop limit offload (diff) | |
| download | linux-dev-e50bfdf74d5f81c81f7a00498aa7fd1cba53b65b.tar.xz linux-dev-e50bfdf74d5f81c81f7a00498aa7fd1cba53b65b.zip | |
nfp: flower: remove unnecessary iteration over devices
For flower tunnel offloads FW has to be informed about MAC addresses
of tunnel devices. We use a netdev notifier to keep track of these
addresses.
Remove unnecessary loop over netdevices after notifier is registered.
The intention of the loop was to catch devices which already existed
on the system before nfp driver got loaded, but netdev notifier will
replay NETDEV_REGISTER events.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: John Hurley <john.hurley@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c')
| -rw-r--r-- | drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c index 8e5bec04d1f9..a3a44f1187d3 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c +++ b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c @@ -686,7 +686,6 @@ static int nfp_tun_mac_event_handler(struct notifier_block *nb, int nfp_tunnel_config_start(struct nfp_app *app) { struct nfp_flower_priv *priv = app->priv; - struct net_device *netdev; int err; /* Initialise priv data for MAC offloading. */ @@ -715,12 +714,6 @@ int nfp_tunnel_config_start(struct nfp_app *app) if (err) goto err_unreg_mac_nb; - /* Parse netdevs already registered for MACs that need offloaded. */ - rtnl_lock(); - for_each_netdev(&init_net, netdev) - nfp_tun_add_to_mac_offload_list(netdev, app); - rtnl_unlock(); - return 0; err_unreg_mac_nb: |