diff options
| author |   Jakub Kicinski <jakub.kicinski@netronome.com> | 2018-02-07 20:55:24 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-02-08 10:01:27 -0500 |
| commit | d692403e5cf8008f31f5664a6f3ce3e65d54f458 (patch) | |
| tree | 497dfc82655e28d9159888154ad9d23248f9d176 /drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | |
| parent | nfp: don't advertise hw-tc-offload on non-port netdevs (diff) | |
| download | linux-dev-d692403e5cf8008f31f5664a6f3ce3e65d54f458.tar.xz linux-dev-d692403e5cf8008f31f5664a6f3ce3e65d54f458.zip | |
nfp: forbid disabling hw-tc-offload on representors while offload active
All netdevs which can accept TC offloads must implement
.ndo_set_features(). nfp_reprs currently do not do that, which
means hw-tc-offload can be turned on and off even when offloads
are active.
Whether the offloads are active is really a question to nfp_ports,
so remove the per-app tc_busy callback indirection thing, and
simply count the number of offloaded items in nfp_port structure.
Fixes: 8a2768732a4d ("nfp: provide infrastructure for offloading flower based TC filters")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Tested-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/netronome/nfp/nfp_net_repr.c')
| -rw-r--r-- | drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c index f67da6bde9da..619570524d2a 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c @@ -265,6 +265,7 @@ const struct net_device_ops nfp_repr_netdev_ops = { .ndo_set_vf_spoofchk = nfp_app_set_vf_spoofchk, .ndo_get_vf_config = nfp_app_get_vf_config, .ndo_set_vf_link_state = nfp_app_set_vf_link_state, + .ndo_set_features = nfp_port_set_features, }; static void nfp_repr_clean(struct nfp_repr *repr) |