aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/octeon
diff options
context:
space:
mode:
authorRussell King <rmk+kernel@arm.linux.org.uk>2013-06-27 13:57:32 +0100
committerRussell King <rmk+kernel@arm.linux.org.uk>2013-10-31 14:48:57 +0000
commit26741a69d1a5e99c4acfea1f5b1d1e652516d4ca (patch)
treed51ae65d6754ea667f57e4100d675191a287d7b1 /drivers/net/ethernet/octeon
parentDMA-API: net: nxp/lpc_eth: use dma_coerce_mask_and_coherent() (diff)
downloadlinux-dev-26741a69d1a5e99c4acfea1f5b1d1e652516d4ca.tar.xz
linux-dev-26741a69d1a5e99c4acfea1f5b1d1e652516d4ca.zip
DMA-API: net: octeon: use dma_coerce_mask_and_coherent()
The code sequence: pdev->dev.coherent_dma_mask = DMA_BIT_MASK(64); pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; bypasses the architectures check on the DMA mask. It can be replaced with dma_coerce_mask_and_coherent(), avoiding the direct initialization of this mask. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'drivers/net/ethernet/octeon')
-rw-r--r--drivers/net/ethernet/octeon/octeon_mgmt.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c
index 622aa75904c4..2006a0700482 100644
--- a/drivers/net/ethernet/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/octeon/octeon_mgmt.c
@@ -1552,8 +1552,9 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
p->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
- pdev->dev.coherent_dma_mask = DMA_BIT_MASK(64);
- pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
+ result = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
+ if (result)
+ goto err;
netif_carrier_off(netdev);
result = register_netdev(netdev);