diff options
| author |   Markus Elfring <elfring@users.sourceforge.net> | 2019-08-22 20:02:56 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-22 16:22:04 -0700 |
| commit | 399e06a517b6f1da5f617d413f6e5489f5054f7a (patch) | |
| tree | 6d406a7734d005746d300bd75f332dae2c961b01 /drivers/net/ethernet/packetengines/yellowfin.c | |
| parent | net: usb: Delete unnecessary checks before the macro call “dev_kfree_skb” (diff) | |
| download | linux-dev-399e06a517b6f1da5f617d413f6e5489f5054f7a.tar.xz linux-dev-399e06a517b6f1da5f617d413f6e5489f5054f7a.zip | |
ethernet: Delete unnecessary checks before the macro call “dev_kfree_skb”
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/packetengines/yellowfin.c')
| -rw-r--r-- | drivers/net/ethernet/packetengines/yellowfin.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c index 6f8d6584f809..5113ee647090 100644 --- a/drivers/net/ethernet/packetengines/yellowfin.c +++ b/drivers/net/ethernet/packetengines/yellowfin.c @@ -1258,8 +1258,7 @@ static int yellowfin_close(struct net_device *dev) yp->rx_skbuff[i] = NULL; } for (i = 0; i < TX_RING_SIZE; i++) { - if (yp->tx_skbuff[i]) - dev_kfree_skb(yp->tx_skbuff[i]); + dev_kfree_skb(yp->tx_skbuff[i]); yp->tx_skbuff[i] = NULL; } |