diff options
| author |   Shannon Nelson <snelson@pensando.io> | 2019-09-30 20:03:22 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-02 11:55:12 -0400 |
| commit | da0729e8d2ae3f2e725b4fa8c3bf99eeb12debec (patch) | |
| tree | 1f6339a0358eafd6e6ab8fe042583d6ed0569423 /drivers/net/ethernet/pensando/ionic | |
| parent | Merge branch 'per-netns-notifier' (diff) | |
| download | linux-dev-da0729e8d2ae3f2e725b4fa8c3bf99eeb12debec.tar.xz linux-dev-da0729e8d2ae3f2e725b4fa8c3bf99eeb12debec.zip | |
ionic: simplify returns in devlink info
There is no need for a goto in this bit of code.
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/pensando/ionic')
| -rw-r--r-- | drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c index af1647afa4e8..6fb27dcc5787 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c @@ -19,31 +19,30 @@ static int ionic_dl_info_get(struct devlink *dl, struct devlink_info_req *req, err = devlink_info_driver_name_put(req, IONIC_DRV_NAME); if (err) - goto info_out; + return err; err = devlink_info_version_running_put(req, DEVLINK_INFO_VERSION_GENERIC_FW, idev->dev_info.fw_version); if (err) - goto info_out; + return err; snprintf(buf, sizeof(buf), "0x%x", idev->dev_info.asic_type); err = devlink_info_version_fixed_put(req, DEVLINK_INFO_VERSION_GENERIC_ASIC_ID, buf); if (err) - goto info_out; + return err; snprintf(buf, sizeof(buf), "0x%x", idev->dev_info.asic_rev); err = devlink_info_version_fixed_put(req, DEVLINK_INFO_VERSION_GENERIC_ASIC_REV, buf); if (err) - goto info_out; + return err; err = devlink_info_serial_number_put(req, idev->dev_info.serial_num); -info_out: return err; } |