diff options
| author |   Leon Romanovsky <leonro@nvidia.com> | 2021-09-22 11:58:03 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-09-22 14:15:12 +0100 |
| commit | db4278c55fa53760893266538e86e638330b03bb (patch) | |
| tree | c2b028bf752e268e9a85791aa199db4f559b80be /drivers/net/ethernet/pensando | |
| parent | net/ipv4/sysctl_net_ipv4.c: remove superfluous header files from sysctl_net_ipv4.c (diff) | |
| download | linux-dev-db4278c55fa53760893266538e86e638330b03bb.tar.xz linux-dev-db4278c55fa53760893266538e86e638330b03bb.zip | |
devlink: Make devlink_register to be void
devlink_register() can't fail and always returns success, but all drivers
are obligated to check returned status anyway. This adds a lot of boilerplate
code to handle impossible flow.
Make devlink_register() void and simplify the drivers that use that
API call.
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Vladimir Oltean <olteanv@gmail.com> # dsa
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/pensando')
| -rw-r--r-- | drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c index c7d0e195d176..93282394d332 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c @@ -82,12 +82,7 @@ int ionic_devlink_register(struct ionic *ionic) struct devlink_port_attrs attrs = {}; int err; - err = devlink_register(dl); - if (err) { - dev_warn(ionic->dev, "devlink_register failed: %d\n", err); - return err; - } - + devlink_register(dl); attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL; devlink_port_attrs_set(&ionic->dl_port, &attrs); err = devlink_port_register(dl, &ionic->dl_port, 0); |