diff options
| author |   Harshvardhan Jha <harshvardhan.jha@oracle.com> | 2021-07-25 23:28:04 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-07-25 23:02:45 +0100 |
| commit | 795e3d2ea68e489ee7039ac29e98bfea0e34a96c (patch) | |
| tree | 5c694fcf91354e8d1fd3000c98cdae1f07cc5c60 /drivers/net/ethernet/qlogic/qede/qede_filter.c | |
| parent | mlx4: Fix missing error code in mlx4_load_one() (diff) | |
| download | linux-dev-795e3d2ea68e489ee7039ac29e98bfea0e34a96c.tar.xz linux-dev-795e3d2ea68e489ee7039ac29e98bfea0e34a96c.zip | |
net: qede: Fix end of loop tests for list_for_each_entry
The list_for_each_entry() iterator, "vlan" in this code, can never be
NULL so the warning will never be printed.
Signed-off-by: Harshvardhan Jha <harshvardhan.jha@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qede/qede_filter.c')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qede/qede_filter.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c index c59b72c90293..a2e4dfb5cb44 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c @@ -831,7 +831,7 @@ int qede_configure_vlan_filters(struct qede_dev *edev) int qede_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid) { struct qede_dev *edev = netdev_priv(dev); - struct qede_vlan *vlan = NULL; + struct qede_vlan *vlan; int rc = 0; DP_VERBOSE(edev, NETIF_MSG_IFDOWN, "Removing vlan 0x%04x\n", vid); @@ -842,7 +842,7 @@ int qede_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid) if (vlan->vid == vid) break; - if (!vlan || (vlan->vid != vid)) { + if (list_entry_is_head(vlan, &edev->vlan_list, list)) { DP_VERBOSE(edev, (NETIF_MSG_IFUP | NETIF_MSG_IFDOWN), "Vlan isn't configured\n"); goto out; |