diff options
| author |   Vladimir Zapolskiy <vz@mleia.com> | 2015-05-26 03:49:45 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-05-28 20:14:45 -0700 |
| commit | d7a32b6e6b1ad361ea89805855ef82dd1dea9128 (patch) | |
| tree | df7f67f44ad0a9538d714e88c8da8fca68d38f5c /drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | |
| parent | treewide: Add missing vmalloc.h inclusion. (diff) | |
| download | linux-dev-d7a32b6e6b1ad361ea89805855ef82dd1dea9128.tar.xz linux-dev-d7a32b6e6b1ad361ea89805855ef82dd1dea9128.zip | |
net: qlcnic: clean up sysfs error codes
Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL
and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the
latter error code is arguable, but it is already used in the driver,
so let it be here as well.
Also remove always false (!buf) check on read(), the driver should
not care if userspace gets its EFAULT or not.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 367f3976df56..2f6cc423ab1d 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -1031,7 +1031,7 @@ int qlcnic_init_pci_info(struct qlcnic_adapter *adapter) pfn = pci_info[i].id; if (pfn >= ahw->max_vnic_func) { - ret = QL_STATUS_INVALID_PARAM; + ret = -EINVAL; dev_err(&adapter->pdev->dev, "%s: Invalid function 0x%x, max 0x%x\n", __func__, pfn, ahw->max_vnic_func); goto err_eswitch; |