diff options
| author |   Aditya Pakki <pakki001@umn.edu> | 2019-03-14 15:31:40 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-15 11:55:53 -0700 |
| commit | 5bf7295fe34a5251b1d241b9736af4697b590670 (patch) | |
| tree | f498356fe345f144e25c6830e66f9c86c6f93f0b /drivers/net/ethernet/qlogic/qlcnic | |
| parent | net: stmmac: fix jumbo frame sending with non-linear skbs (diff) | |
| download | linux-dev-5bf7295fe34a5251b1d241b9736af4697b590670.tar.xz linux-dev-5bf7295fe34a5251b1d241b9736af4697b590670.zip | |
qlcnic: Avoid potential NULL pointer dereference
netdev_alloc_skb can fail and return a NULL pointer which is
dereferenced without a check. The patch avoids such a scenario.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qlcnic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index 3b0adda7cc9c..a4cd6f2cfb86 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1048,6 +1048,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); + if (!skb) + break; qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); skb_put(skb, QLCNIC_ILB_PKT_SIZE); adapter->ahw->diag_cnt = 0; |