diff options
| author |   Pan Bian <bianpan2016@163.com> | 2017-04-23 20:04:04 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-04-24 16:10:53 -0400 |
| commit | 91ec701a553cb3de470fd471c6fefe3ad1125455 (patch) | |
| tree | 542d0fcd16478312c482e5a629fdf0210d44077d /drivers/net/ethernet/qlogic/qlcnic | |
| parent | wan: pc300too: abort path on failure (diff) | |
| download | linux-dev-91ec701a553cb3de470fd471c6fefe3ad1125455.tar.xz linux-dev-91ec701a553cb3de470fd471c6fefe3ad1125455.zip | |
qlcnic: fix unchecked return value
Function pci_find_ext_capability() may return 0, which is an invalid
address. In function qlcnic_sriov_virtid_fn(), its return value is used
without validation. This may result in invalid memory access bugs. This
patch fixes the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qlcnic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c index d7107055ec60..2f656f395f39 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c @@ -128,6 +128,8 @@ static int qlcnic_sriov_virtid_fn(struct qlcnic_adapter *adapter, int vf_id) return 0; pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_SRIOV); + if (!pos) + return 0; pci_read_config_word(dev, pos + PCI_SRIOV_VF_OFFSET, &offset); pci_read_config_word(dev, pos + PCI_SRIOV_VF_STRIDE, &stride); |