diff options
| author |   Sinan Kaya <okaya@codeaurora.org> | 2018-03-25 10:39:16 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-26 12:47:55 -0400 |
| commit | f9442ac498a86b1b0ec383a332be2635fbb1ed98 (patch) | |
| tree | 265762dc52f5a1e0bc31bba3e34df3c4dcea04e6 /drivers/net/ethernet/qlogic/qlcnic | |
| parent | net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs (diff) | |
| download | linux-dev-f9442ac498a86b1b0ec383a332be2635fbb1ed98.tar.xz linux-dev-f9442ac498a86b1b0ec383a332be2635fbb1ed98.zip | |
qlcnic: Eliminate duplicate barriers on weakly-ordered archs
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing writel() to
writel_relaxed().
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Manish Chopra <manish.chopra@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qlcnic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 46b0372dd032..97c146e7698a 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter) wmb(); /* clear the interrupt trigger control register */ - writel(0, adapter->isr_int_vec); + writel_relaxed(0, adapter->isr_int_vec); intr_val = readl(adapter->isr_int_vec); do { intr_val = readl(adapter->tgt_status_reg); |