diff options
| author |   Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com> | 2016-06-28 02:10:58 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-06-29 07:53:35 -0400 |
| commit | 51d99880879c8911ebcab1ec77ca7da2f4cb470d (patch) | |
| tree | c57afae30a8d0190790e70f85ece20445696d9ea /drivers/net/ethernet/qlogic | |
| parent | net: ethernet: mvpp2: use phy_ethtool_{get|set}_link_ksettings (diff) | |
| download | linux-dev-51d99880879c8911ebcab1ec77ca7da2f4cb470d.tar.xz linux-dev-51d99880879c8911ebcab1ec77ca7da2f4cb470d.zip | |
qed: Fix static checker warnings.
Static checker warnings:
drivers/net/ethernet/qlogic/qed/qed_int.c:2450 qed_init_cau_sb_entry()
warn: always true condition '(cdev->rx_coalesce_usecs <= 255) =>
(0-255 <= 255)'
drivers/net/ethernet/qlogic/qed/qed_int.c:2511 qed_int_cau_conf_sb()
warn: always true condition '(p_hwfn->cdev->rx_coalesce_usecs <= 255)
=> (0-255 <= 255)'
..
The data types for rx/tx_coalesce_usecs should be u16.
Fixes: commit 722003ac40c2 ("qed: Add support for coalescing config read/update.")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed.h b/drivers/net/ethernet/qlogic/qed/qed.h index 9a63df1184f1..35e53771533f 100644 --- a/drivers/net/ethernet/qlogic/qed/qed.h +++ b/drivers/net/ethernet/qlogic/qed/qed.h @@ -489,8 +489,8 @@ struct qed_dev { u32 int_mode; enum qed_coalescing_mode int_coalescing_mode; - u8 rx_coalesce_usecs; - u8 tx_coalesce_usecs; + u16 rx_coalesce_usecs; + u16 tx_coalesce_usecs; /* Start Bar offset of first hwfn */ void __iomem *regview; |