diff options
| author |   Yuval Mintz <Yuval.Mintz@qlogic.com> | 2016-09-19 17:47:41 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-09-20 04:57:16 -0400 |
| commit | 67a99b7061c07b190ac6c39f136afedbb7aa86e9 (patch) | |
| tree | 94cabd2638bcde1004dec702d713f1f4e1c6e41d /drivers/net/ethernet/qlogic | |
| parent | MAINTAINERS: Add an entry for the core network DSA code (diff) | |
| download | linux-dev-67a99b7061c07b190ac6c39f136afedbb7aa86e9.tar.xz linux-dev-67a99b7061c07b190ac6c39f136afedbb7aa86e9.zip | |
qed: Fix stack corruption on probe
Commit fe56b9e6a8d95 ("qed: Add module with basic common support")
has introduced a stack corruption during probe, where filling a
local struct with data to be sent to management firmware is incorrectly
filled; The data is written outside of the struct and corrupts
the stack.
Changes from v1:
----------------
- Correct the value written [Caught by David Laight]
Fixes: fe56b9e6a8d95 ("qed: Add module with basic common support")
Signed-off-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_mcp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c index a240f26344a4..f776a77794c5 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c @@ -1153,8 +1153,8 @@ qed_mcp_send_drv_version(struct qed_hwfn *p_hwfn, p_drv_version = &union_data.drv_version; p_drv_version->version = p_ver->version; - for (i = 0; i < MCP_DRV_VER_STR_SIZE - 1; i += 4) { - val = cpu_to_be32(p_ver->name[i]); + for (i = 0; i < (MCP_DRV_VER_STR_SIZE - 4) / sizeof(u32); i++) { + val = cpu_to_be32(*((u32 *)&p_ver->name[i * sizeof(u32)])); *(__be32 *)&p_drv_version->name[i * sizeof(u32)] = val; } |