diff options
| author |   Markus Elfring <elfring@users.sourceforge.net> | 2019-08-22 20:02:56 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-22 16:22:04 -0700 |
| commit | 399e06a517b6f1da5f617d413f6e5489f5054f7a (patch) | |
| tree | 6d406a7734d005746d300bd75f332dae2c961b01 /drivers/net/ethernet/qualcomm | |
| parent | net: usb: Delete unnecessary checks before the macro call “dev_kfree_skb” (diff) | |
| download | linux-dev-399e06a517b6f1da5f617d413f6e5489f5054f7a.tar.xz linux-dev-399e06a517b6f1da5f617d413f6e5489f5054f7a.zip | |
ethernet: Delete unnecessary checks before the macro call “dev_kfree_skb”
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qualcomm')
| -rw-r--r-- | drivers/net/ethernet/qualcomm/qca_spi.c | 3 | ||||
| -rw-r--r-- | drivers/net/ethernet/qualcomm/qca_uart.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index b28360bc2255..5ecf61df78bd 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -837,8 +837,7 @@ qcaspi_netdev_uninit(struct net_device *dev) kfree(qca->rx_buffer); qca->buffer_size = 0; - if (qca->rx_skb) - dev_kfree_skb(qca->rx_skb); + dev_kfree_skb(qca->rx_skb); } static const struct net_device_ops qcaspi_netdev_ops = { diff --git a/drivers/net/ethernet/qualcomm/qca_uart.c b/drivers/net/ethernet/qualcomm/qca_uart.c index 590616846cd1..0981068504fa 100644 --- a/drivers/net/ethernet/qualcomm/qca_uart.c +++ b/drivers/net/ethernet/qualcomm/qca_uart.c @@ -285,8 +285,7 @@ static void qcauart_netdev_uninit(struct net_device *dev) { struct qcauart *qca = netdev_priv(dev); - if (qca->rx_skb) - dev_kfree_skb(qca->rx_skb); + dev_kfree_skb(qca->rx_skb); } static const struct net_device_ops qcauart_netdev_ops = { |