diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2016-12-08 22:57:05 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-12-08 21:30:54 -0500 |
| commit | f006b2c5dff35cb32ee77a0cbcabb52d90118c19 (patch) | |
| tree | 6cf146ac98bcde1e952430951046a9186227c6db /drivers/net/ethernet/qualcomm | |
| parent | net: xgene: move xgene_cle_ptree_ewdn data off stack (diff) | |
| download | linux-dev-f006b2c5dff35cb32ee77a0cbcabb52d90118c19.tar.xz linux-dev-f006b2c5dff35cb32ee77a0cbcabb52d90118c19.zip | |
net: xgene: avoid bogus maybe-uninitialized warning
In some configurations, gcc cannot trace the state of variables
across a spin_unlock() barrier, leading to a warning about
correct code:
xgene_enet_main.c: In function 'xgene_enet_start_xmit':
../../../phy/mdio-xgene.h:112:14: error: 'mss_index' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Here we can trivially move the assignment before that spin_unlock,
which reliably avoids the warning.
Fixes: e3978673f514 ("drivers: net: xgene: Fix MSS programming")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qualcomm')
0 files changed, 0 insertions, 0 deletions