diff options
| author |   Heiner Kallweit <hkallweit1@gmail.com> | 2021-08-24 08:23:20 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-08-24 10:50:26 +0100 |
| commit | 18a9eae240cb24d4771fed746c70662c0926a9e8 (patch) | |
| tree | 4b2d023bafdf7ba3ac337f9e2f5f2d7d2bcca5bf /drivers/net/ethernet/realtek | |
| parent | page_pool: use relaxed atomic for release side accounting (diff) | |
| download | linux-dev-18a9eae240cb24d4771fed746c70662c0926a9e8.tar.xz linux-dev-18a9eae240cb24d4771fed746c70662c0926a9e8.zip | |
r8169: enable ASPM L0s state
ASPM is disabled completely because we've seen different types of
problems in the past. However it seems these problems occurred with
L1 or L1 sub-states only. On all the chip versions I've seen the
acceptable L0s exit latency is 512ns. This should be short enough not
to cause problems. If the actual L0s exit latency of the PCIe link
is bigger than 512ns then the PCI core will disable L0s anyway.
So let's give it a try and disable L1 and L1 sub-states only.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/realtek')
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169_main.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 7a69b468584a..9ea59efd0fd6 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5281,11 +5281,10 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) if (rc) return rc; - /* Disable ASPM completely as that cause random device stop working + /* Disable ASPM L1 as that cause random device stop working * problems as well as full system hangs for some PCIe devices users. */ - rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | - PCIE_LINK_STATE_L1); + rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L1); tp->aspm_manageable = !rc; /* enable device (incl. PCI PM wakeup and hotplug setup) */ |