diff options
| author |   Kees Cook <keescook@chromium.org> | 2021-06-16 12:53:59 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-16 13:02:07 -0700 |
| commit | da5ac772cfe2a03058b0accfac03fad60c46c24d (patch) | |
| tree | fe1d65a1a86473e33f29563c3d1d9c36f0d7bef0 /drivers/net/ethernet/realtek | |
| parent | sh_eth: Avoid memcpy() over-reading of ETH_SS_STATS (diff) | |
| download | linux-dev-da5ac772cfe2a03058b0accfac03fad60c46c24d.tar.xz linux-dev-da5ac772cfe2a03058b0accfac03fad60c46c24d.zip | |
r8169: Avoid memcpy() over-reading of ETH_SS_STATS
In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memcpy(), memmove(), and memset(), avoid
intentionally reading across neighboring array fields.
The memcpy() is copying the entire structure, not just the first array.
Adjust the source argument so the compiler can do appropriate bounds
checking.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/realtek')
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 2c89cde7da1e..2ee72dc431cd 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -1671,7 +1671,7 @@ static void rtl8169_get_strings(struct net_device *dev, u32 stringset, u8 *data) { switch(stringset) { case ETH_SS_STATS: - memcpy(data, *rtl8169_gstrings, sizeof(rtl8169_gstrings)); + memcpy(data, rtl8169_gstrings, sizeof(rtl8169_gstrings)); break; } } |