diff options
| author |   Sergey Shtylyov <s.shtylyov@omp.ru> | 2022-01-28 21:32:40 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-01-31 11:30:56 +0000 |
| commit | 73c105ad2a3e142d81fc59761ce8353d0b211b8f (patch) | |
| tree | 5fd499167ca8b5770bcfda9a932465f8ee5b4d43 /drivers/net/ethernet/renesas/sh_eth.c | |
| parent | Merge branch 'dsa-mv88e6xxx-Improve-indirect-addressing-performance' (diff) | |
| download | linux-dev-73c105ad2a3e142d81fc59761ce8353d0b211b8f.tar.xz linux-dev-73c105ad2a3e142d81fc59761ce8353d0b211b8f.zip | |
phy: make phy_set_max_speed() *void*
After following the call tree of phy_set_max_speed(), it became clear
that this function never returns anything but 0, so we can change its
result type to *void* and drop the result checks from the three drivers
that actually bothered to do it...
Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/renesas/sh_eth.c')
| -rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index d947a628e166..8aa91e99227d 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2026,14 +2026,8 @@ static int sh_eth_phy_init(struct net_device *ndev) } /* mask with MAC supported features */ - if (mdp->cd->register_type != SH_ETH_REG_GIGABIT) { - int err = phy_set_max_speed(phydev, SPEED_100); - if (err) { - netdev_err(ndev, "failed to limit PHY to 100 Mbit/s\n"); - phy_disconnect(phydev); - return err; - } - } + if (mdp->cd->register_type != SH_ETH_REG_GIGABIT) + phy_set_max_speed(phydev, SPEED_100); phy_attached_info(phydev); |