diff options
| author |   Edward Cree <ecree@solarflare.com> | 2020-05-11 13:29:45 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-05-11 13:31:49 -0700 |
| commit | ed02112cff9212232cc42f871cbe84c2c4c81850 (patch) | |
| tree | d5573c1a07d473256a68988004b7b824276ec149 /drivers/net/ethernet/sfc/ef10.c | |
| parent | sfc: move rx_rss_context_exclusive into struct efx_mcdi_filter_table (diff) | |
| download | linux-dev-ed02112cff9212232cc42f871cbe84c2c4c81850.tar.xz linux-dev-ed02112cff9212232cc42f871cbe84c2c4c81850.zip | |
sfc: make filter table probe caller responsible for adding VLANs
By making the caller of efx_mcdi_filter_table_probe() loop over the
vlan_list calling efx_mcdi_filter_add_vlan(), instead of doing it in
efx_mcdi_filter_table_probe(), the latter avoids looking in ef10-
specific nic_data.
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/ef10.c')
| -rw-r--r-- | drivers/net/ethernet/sfc/ef10.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 0779dda7d29f..d7d2edc4d81a 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -2447,6 +2447,7 @@ static int efx_ef10_filter_table_probe(struct efx_nic *efx) { struct efx_ef10_nic_data *nic_data = efx->nic_data; int rc = efx_ef10_probe_multicast_chaining(efx); + struct efx_mcdi_filter_vlan *vlan; if (rc) return rc; @@ -2455,7 +2456,16 @@ static int efx_ef10_filter_table_probe(struct efx_nic *efx) if (rc) return rc; + list_for_each_entry(vlan, &nic_data->vlan_list, list) { + rc = efx_mcdi_filter_add_vlan(efx, vlan->vid); + if (rc) + goto fail_add_vlan; + } return 0; + +fail_add_vlan: + efx_mcdi_filter_table_remove(efx); + return rc; } /* This creates an entry in the RX descriptor queue */ |