diff options
| author |   Martin Habets <mhabets@solarflare.com> | 2015-11-02 12:51:31 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-11-02 23:02:58 -0500 |
| commit | b2663a4f30e85ec606b806f5135413e6d5c78d1e (patch) | |
| tree | 115a16d89b46e332254fe2cdf3b1087f95e97391 /drivers/net/ethernet/sfc/farch.c | |
| parent | sit: fix sit0 percpu double allocations (diff) | |
| download | linux-dev-b2663a4f30e85ec606b806f5135413e6d5c78d1e.tar.xz linux-dev-b2663a4f30e85ec606b806f5135413e6d5c78d1e.zip | |
sfc: push partner queue for skb->xmit_more
When the IP stack passes SKBs the sfc driver puts them in 2 different TX
queues (called partners), one for checksummed and one for not checksummed.
If the SKB has xmit_more set the driver will delay pushing the work to the
NIC.
When later it does decide to push the buffers this patch ensures it also
pushes the partner queue, if that also has any delayed work. Before this
fix the work in the partner queue would be left for a long time and cause
a netdev watchdog.
Fixes: 70b33fb ("sfc: add support for skb->xmit_more")
Reported-by: Jianlin Shi <jishi@redhat.com>
Signed-off-by: Martin Habets <mhabets@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/farch.c')
| -rw-r--r-- | drivers/net/ethernet/sfc/farch.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/farch.c b/drivers/net/ethernet/sfc/farch.c index f08266f0eca2..5a1c5a8f278a 100644 --- a/drivers/net/ethernet/sfc/farch.c +++ b/drivers/net/ethernet/sfc/farch.c @@ -321,7 +321,9 @@ void efx_farch_tx_write(struct efx_tx_queue *tx_queue) unsigned write_ptr; unsigned old_write_count = tx_queue->write_count; - BUG_ON(tx_queue->write_count == tx_queue->insert_count); + tx_queue->xmit_more_available = false; + if (unlikely(tx_queue->write_count == tx_queue->insert_count)) + return; do { write_ptr = tx_queue->write_count & tx_queue->ptr_mask; |