diff options
| author |   Ben Hutchings <bhutchings@solarflare.com> | 2012-09-19 00:31:18 +0100 |
|---|---|---|
| committer | Ben Hutchings <bhutchings@solarflare.com> | 2012-12-01 01:56:22 +0000 |
| commit | c3771a35bebeea16c4fd94d1116010cc02b1f75e (patch) | |
| tree | e29ba609fba85c1fe451443cb52e326144fb552b /drivers/net/ethernet/sfc | |
| parent | sfc: Correctly initialise reset_method in siena_test_chip() (diff) | |
| download | linux-dev-c3771a35bebeea16c4fd94d1116010cc02b1f75e.tar.xz linux-dev-c3771a35bebeea16c4fd94d1116010cc02b1f75e.zip | |
sfc: Do not initialise buffer in efx_alloc_special_buffer()
Currently we initialise the newly allocated buffer to all-1s, which is
important for event queues but not for descriptor queues. And since
we also do that in efx_nic_init_eventq(), it is completely pointless
to do it here.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Diffstat (limited to 'drivers/net/ethernet/sfc')
| -rw-r--r-- | drivers/net/ethernet/sfc/nic.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/sfc/nic.c b/drivers/net/ethernet/sfc/nic.c index 368659d6362a..1327f29d086f 100644 --- a/drivers/net/ethernet/sfc/nic.c +++ b/drivers/net/ethernet/sfc/nic.c @@ -255,9 +255,6 @@ static int efx_alloc_special_buffer(struct efx_nic *efx, buffer->entries = len / EFX_BUF_SIZE; BUG_ON(buffer->dma_addr & (EFX_BUF_SIZE - 1)); - /* All zeros is a potentially valid event so memset to 0xff */ - memset(buffer->addr, 0xff, len); - /* Select new buffer ID */ buffer->index = efx->next_buffer_table; efx->next_buffer_table += buffer->entries; |