diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-04-04 11:45:11 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-04-05 11:55:44 -0700 |
| commit | c438a801e0bb2a4db1d3183a9482af891577a281 (patch) | |
| tree | d5c3d06d3a80bc1f8b6ab375e6c430b7f929343f /drivers/net/ethernet/sfc | |
| parent | ibmvnic: Use 'skb_frag_address()' instead of hand coding it (diff) | |
| download | linux-dev-c438a801e0bb2a4db1d3183a9482af891577a281.tar.xz linux-dev-c438a801e0bb2a4db1d3183a9482af891577a281.zip | |
sfc: Use 'skb_add_rx_frag()' instead of hand coding it
Some lines of code can be merged into an equivalent 'skb_add_rx_frag()'
call which is less verbose.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc')
| -rw-r--r-- | drivers/net/ethernet/sfc/rx.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c index 89c5c75f479f..17b8119c48e5 100644 --- a/drivers/net/ethernet/sfc/rx.c +++ b/drivers/net/ethernet/sfc/rx.c @@ -94,12 +94,11 @@ static struct sk_buff *efx_rx_mk_skb(struct efx_channel *channel, rx_buf->len -= hdr_len; for (;;) { - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags, - rx_buf->page, rx_buf->page_offset, - rx_buf->len); + skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, + rx_buf->page, rx_buf->page_offset, + rx_buf->len, efx->rx_buffer_truesize); rx_buf->page = NULL; - skb->len += rx_buf->len; - skb->data_len += rx_buf->len; + if (skb_shinfo(skb)->nr_frags == n_frags) break; @@ -111,8 +110,6 @@ static struct sk_buff *efx_rx_mk_skb(struct efx_channel *channel, n_frags = 0; } - skb->truesize += n_frags * efx->rx_buffer_truesize; - /* Move past the ethernet header */ skb->protocol = eth_type_trans(skb, efx->net_dev); |