diff options
| author |   Jisheng Zhang <Jisheng.Zhang@synaptics.com> | 2020-04-03 10:23:29 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-04-03 15:58:54 -0700 |
| commit | 3e1221acf6a8f8595b5ce354bab4327a69d54d18 (patch) | |
| tree | 0a6b7d76f567dc85d34071509ccd6cc77ed44b1e /drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | |
| parent | mlxsw: spectrum_trap: fix unintention integer overflow on left shift (diff) | |
| download | linux-dev-3e1221acf6a8f8595b5ce354bab4327a69d54d18.tar.xz linux-dev-3e1221acf6a8f8595b5ce354bab4327a69d54d18.zip | |
net: stmmac: dwmac1000: fix out-of-bounds mac address reg setting
Commit 9463c4455900 ("net: stmmac: dwmac1000: Clear unused address
entries") cleared the unused mac address entries, but introduced an
out-of bounds mac address register programming bug -- After setting
the secondary unicast mac addresses, the "reg" value has reached
netdev_uc_count() + 1, thus we should only clear address entries
if (addr < perfect_addr_number)
Fixes: 9463c4455900 ("net: stmmac: dwmac1000: Clear unused address entries")
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c index 542784300620..efc6ec1b8027 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c @@ -207,7 +207,7 @@ static void dwmac1000_set_filter(struct mac_device_info *hw, reg++; } - while (reg <= perfect_addr_number) { + while (reg < perfect_addr_number) { writel(0, ioaddr + GMAC_ADDR_HIGH(reg)); writel(0, ioaddr + GMAC_ADDR_LOW(reg)); reg++; |