diff options
| author |   Emil Goode <emilgoode@gmail.com> | 2014-06-02 11:30:50 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-06-02 10:38:14 -0700 |
| commit | 86c92ee3a2a22bf87537072f0f2021089ab87395 (patch) | |
| tree | 725cd927b3e977b4b6985dfb4610424ab1330685 /drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | |
| parent | genetlink: remove superfluous assignment (diff) | |
| download | linux-dev-86c92ee3a2a22bf87537072f0f2021089ab87395.tar.xz linux-dev-86c92ee3a2a22bf87537072f0f2021089ab87395.zip | |
stmmac: Remove spin_lock call in stmmac_get_pauseparam()
The following patch removed unnecessary spin_lock/unlock calls
in ethtool_ops callback functions. In the second and final version
of the patch one spin_lock call was left behind.
commit cab6715c3e8029e98b0b5d4056ceda007c0f6380
Author: Yang Wei <Wei.Yang@windriver.com>
Date: Sun May 25 09:53:44 2014 +0800
net: driver: stmicro: Remove some useless the lock protection
This introduced the following sparse warning:
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:424:1: warning:
context imbalance in 'stmmac_get_pauseparam' -
different lock contexts for basic block
Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 78926662d58c..c62e67f3c2f0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -429,8 +429,6 @@ stmmac_get_pauseparam(struct net_device *netdev, if (priv->pcs) /* FIXME */ return; - spin_lock(&priv->lock); - pause->rx_pause = 0; pause->tx_pause = 0; pause->autoneg = priv->phydev->autoneg; |