diff options
| author |   Srinivas Kandagatla <srinivas.kandagatla@st.com> | 2013-07-04 10:35:35 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-07-04 14:34:17 -0700 |
| commit | d741434c3e0ae5592b72a0f4833a42b4be1b2fa1 (patch) | |
| tree | 10378f1e0e36060ba615ca2a4736e597c26176df /drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | |
| parent | net:stmmac: fix memleak in the open method (diff) | |
| download | linux-dev-d741434c3e0ae5592b72a0f4833a42b4be1b2fa1.tar.xz linux-dev-d741434c3e0ae5592b72a0f4833a42b4be1b2fa1.zip | |
dt:net:stmmac: Allocate platform data only if its NULL.
In some DT use-cases platform data might be already allocated and passed
via AUXDATA. These are the cases where machine level code populates few
callbacks in the platform data.
This patch adds check and reuses platform_data if its valid, before
allocating a new one.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 17bc7827e7ca..adfb9a3ce6c5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -92,8 +92,10 @@ static int stmmac_pltfr_probe(struct platform_device *pdev) if (IS_ERR(addr)) return PTR_ERR(addr); + plat_dat = pdev->dev.platform_data; if (pdev->dev.of_node) { - plat_dat = devm_kzalloc(&pdev->dev, + if (!plat_dat) + plat_dat = devm_kzalloc(&pdev->dev, sizeof(struct plat_stmmacenet_data), GFP_KERNEL); if (!plat_dat) { @@ -106,8 +108,6 @@ static int stmmac_pltfr_probe(struct platform_device *pdev) pr_err("%s: main dt probe failed", __func__); return ret; } - } else { - plat_dat = pdev->dev.platform_data; } /* Custom initialisation (if needed)*/ |