diff options
| author |   Grygorii Strashko <grygorii.strashko@ti.com> | 2017-11-30 18:21:20 -0600 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-12-01 16:36:33 -0500 |
| commit | 97193601bb09e18265823f50dd6418d4be2122ce (patch) | |
| tree | 2555c38a3494c7cd68ba9ad764ba38d4e73f140d /drivers/net/ethernet/ti/cpsw_ale.c | |
| parent | net: ethernet: ti: ale: use devm_kzalloc in cpsw_ale_create() (diff) | |
| download | linux-dev-97193601bb09e18265823f50dd6418d4be2122ce.tar.xz linux-dev-97193601bb09e18265823f50dd6418d4be2122ce.zip | |
net: ethernet: ti: ale: fix port check in cpsw_ale_control_set/get
ALE ports number includes the Host port and ext Ports, and
ALE ports numbering starts from 0, so correct corresponding port
checks in cpsw_ale_control_set/get().
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ti/cpsw_ale.c')
| -rw-r--r-- | drivers/net/ethernet/ti/cpsw_ale.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c index e5132482527a..93dc05c194d3 100644 --- a/drivers/net/ethernet/ti/cpsw_ale.c +++ b/drivers/net/ethernet/ti/cpsw_ale.c @@ -723,7 +723,7 @@ int cpsw_ale_control_set(struct cpsw_ale *ale, int port, int control, if (info->port_offset == 0 && info->port_shift == 0) port = 0; /* global, port is a dont care */ - if (port < 0 || port > ale->params.ale_ports) + if (port < 0 || port >= ale->params.ale_ports) return -EINVAL; mask = BITMASK(info->bits); @@ -754,7 +754,7 @@ int cpsw_ale_control_get(struct cpsw_ale *ale, int port, int control) if (info->port_offset == 0 && info->port_shift == 0) port = 0; /* global, port is a dont care */ - if (port < 0 || port > ale->params.ale_ports) + if (port < 0 || port >= ale->params.ale_ports) return -EINVAL; offset = info->offset + (port * info->port_offset); |