diff options
| author |   Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> | 2018-06-13 12:05:16 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-06-14 17:08:03 -0700 |
| commit | 087fca595a0a30804fd7896e77ba11aa46e5d708 (patch) | |
| tree | 706862bd48577e0c1e22315da4e3bcb63f0f2f31 /drivers/net/ethernet/xilinx/xilinx_emaclite.c | |
| parent | tcp: verify the checksum of the first data segment in a new connection (diff) | |
| download | linux-dev-087fca595a0a30804fd7896e77ba11aa46e5d708.tar.xz linux-dev-087fca595a0a30804fd7896e77ba11aa46e5d708.zip | |
net: emaclite: Fix position of lp->mii_bus assignment
To ensure MDIO bus is not double freed in remove() path
assign lp->mii_bus after MDIO bus registration.
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/xilinx/xilinx_emaclite.c')
| -rw-r--r-- | drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 69e31ceccfae..37989ce543ba 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -863,14 +863,14 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) bus->write = xemaclite_mdio_write; bus->parent = dev; - lp->mii_bus = bus; - rc = of_mdiobus_register(bus, np); if (rc) { dev_err(dev, "Failed to register mdio bus.\n"); goto err_register; } + lp->mii_bus = bus; + return 0; err_register: |