diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2012-06-14 08:34:24 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2012-06-15 15:30:15 -0700 |
| commit | 0f6efff92524c65fc3ef41c8b936c526580f1db0 (patch) | |
| tree | 147fe0ff12046cabcb3a4c39d07a751b79707ddb /drivers/net/ethernet | |
| parent | net: remove skb_orphan_try() (diff) | |
| download | linux-dev-0f6efff92524c65fc3ef41c8b936c526580f1db0.tar.xz linux-dev-0f6efff92524c65fc3ef41c8b936c526580f1db0.zip | |
qlcnic: off by one in qlcnic_init_pci_info()
The adapter->npars[] array has QLCNIC_MAX_PCI_FUNC elements. We
allocate it that way a few lines earlier in the function. So this test
is off by one.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 46e77a2c5121..ad98f4d7919d 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -479,7 +479,7 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter) for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++) { pfn = pci_info[i].id; - if (pfn > QLCNIC_MAX_PCI_FUNC) { + if (pfn >= QLCNIC_MAX_PCI_FUNC) { ret = QL_STATUS_INVALID_PARAM; goto err_eswitch; } |