diff options
| author |   sudarsana.kalluru@cavium.com <sudarsana.kalluru@cavium.com> | 2017-05-04 08:15:05 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-05-04 12:31:03 -0400 |
| commit | 161adb046b9119d480f2547db20fc3e9ce7cbf59 (patch) | |
| tree | 4ec0fb247d630bea29fc3d51d56f1d86686b96ac /drivers/net/ethernet | |
| parent | qed: Fix overriding of supported autoneg value. (diff) | |
| download | linux-dev-161adb046b9119d480f2547db20fc3e9ce7cbf59.tar.xz linux-dev-161adb046b9119d480f2547db20fc3e9ce7cbf59.zip | |
qede: Fix possible misconfiguration of advertised autoneg value.
Fail the configuration of advertised speed-autoneg value if the config
update is not supported.
Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c index b22753c5fd44..172b292241a5 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c @@ -493,6 +493,11 @@ static int qede_set_link_ksettings(struct net_device *dev, params.override_flags |= QED_LINK_OVERRIDE_SPEED_ADV_SPEEDS; params.override_flags |= QED_LINK_OVERRIDE_SPEED_AUTONEG; if (base->autoneg == AUTONEG_ENABLE) { + if (!(current_link.supported_caps & QED_LM_Autoneg_BIT)) { + DP_INFO(edev, "Auto negotiation is not supported\n"); + return -EOPNOTSUPP; + } + params.autoneg = true; params.forced_speed = 0; QEDE_ETHTOOL_TO_DRV_CAPS(params.adv_speeds, cmd, advertising) |