diff options
| author |   Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com> | 2016-11-03 08:16:20 -0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-11-03 16:25:37 -0400 |
| commit | 29ab5a3b94c87382da06db88e96119911d557293 (patch) | |
| tree | ee5367a19ef5776c7b578f7f874b7772b250c942 /drivers/net/ethernet | |
| parent | ipv6: dccp: fix out of bound access in dccp_v6_err() (diff) | |
| download | linux-dev-29ab5a3b94c87382da06db88e96119911d557293.tar.xz linux-dev-29ab5a3b94c87382da06db88e96119911d557293.zip | |
ehea: fix operation state report
Currently the ehea driver is missing a call to netif_carrier_off()
before the interface bring-up; this is necessary in order to
initialize the __LINK_STATE_NOCARRIER bit in the net_device state
field. Otherwise, we observe state UNKNOWN on "ip address" command
output.
This patch adds a call to netif_carrier_off() on ehea's net device
open callback.
Reported-by: Xiong Zhou <zhou@redhat.com>
Reference-ID: IBM bz #137702, Red Hat bz #1089134
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 54efa9a5167b..bd719e25dd76 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -2446,6 +2446,8 @@ static int ehea_open(struct net_device *dev) netif_info(port, ifup, dev, "enabling port\n"); + netif_carrier_off(dev); + ret = ehea_up(dev); if (!ret) { port_napi_enable(port); |