diff options
| author |   Esben Haabendal <esben@geanix.com> | 2019-05-07 08:42:57 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-05-07 12:24:45 -0700 |
| commit | 5db9c74042e3c2168b1f1104d691063f5b662a8b (patch) | |
| tree | 6f36db2fc0bed954b37181cf68e4c45c8633ddc1 /drivers/net/ethernet | |
| parent | net/sched: remove block pointer from common offload structure (diff) | |
| download | linux-dev-5db9c74042e3c2168b1f1104d691063f5b662a8b.tar.xz linux-dev-5db9c74042e3c2168b1f1104d691063f5b662a8b.zip | |
net: ll_temac: Improve error message on error IRQ
The channel status register value can be very helpful when debugging
SDMA problems.
Signed-off-by: Esben Haabendal <esben@geanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/xilinx/ll_temac_main.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index f389a819f058..997475c209c0 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -886,8 +886,10 @@ static irqreturn_t ll_temac_tx_irq(int irq, void *_ndev) if (status & (IRQ_COAL | IRQ_DLY)) temac_start_xmit_done(lp->ndev); - if (status & 0x080) - dev_err(&ndev->dev, "DMA error 0x%x\n", status); + if (status & (IRQ_ERR | IRQ_DMAERR)) + dev_err_ratelimited(&ndev->dev, + "TX error 0x%x TX_CHNL_STS=0x%08x\n", + status, lp->dma_in(lp, TX_CHNL_STS)); return IRQ_HANDLED; } @@ -904,6 +906,10 @@ static irqreturn_t ll_temac_rx_irq(int irq, void *_ndev) if (status & (IRQ_COAL | IRQ_DLY)) ll_temac_recv(lp->ndev); + if (status & (IRQ_ERR | IRQ_DMAERR)) + dev_err_ratelimited(&ndev->dev, + "RX error 0x%x RX_CHNL_STS=0x%08x\n", + status, lp->dma_in(lp, RX_CHNL_STS)); return IRQ_HANDLED; } |