diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2014-08-07 21:20:12 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-08-07 16:02:57 -0700 |
| commit | 888c88b857cd974e65e6cacb0aece0dfdf9f27d1 (patch) | |
| tree | ef7b3ed948f3a0c3822d904e8be4aeed118b4ffb /drivers/net/ethernet | |
| parent | drivers/atm/atmtcp.c: fix error return code (diff) | |
| download | linux-dev-888c88b857cd974e65e6cacb0aece0dfdf9f27d1.tar.xz linux-dev-888c88b857cd974e65e6cacb0aece0dfdf9f27d1.zip | |
net: gianfar: no need to check parameter being != NULL for of_node_put
of_node_put is a noop when being called with NULL.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/freescale/gianfar.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index a6cf40e62f3a..6b0c4775cd0d 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1435,10 +1435,8 @@ register_fail: unmap_group_regs(priv); gfar_free_rx_queues(priv); gfar_free_tx_queues(priv); - if (priv->phy_node) - of_node_put(priv->phy_node); - if (priv->tbi_node) - of_node_put(priv->tbi_node); + of_node_put(priv->phy_node); + of_node_put(priv->tbi_node); free_gfar_dev(priv); return err; } @@ -1447,10 +1445,8 @@ static int gfar_remove(struct platform_device *ofdev) { struct gfar_private *priv = platform_get_drvdata(ofdev); - if (priv->phy_node) - of_node_put(priv->phy_node); - if (priv->tbi_node) - of_node_put(priv->tbi_node); + of_node_put(priv->phy_node); + of_node_put(priv->tbi_node); unregister_netdev(priv->ndev); unmap_group_regs(priv); |