diff options
| author |   Jakub Kicinski <jakub.kicinski@netronome.com> | 2018-11-27 22:24:57 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-11-30 13:30:44 -0800 |
| commit | 9571d9877546434682b653e8a81a5a177cd4529e (patch) | |
| tree | c011cbc33a22f7c76ba163c226506eac137308da /drivers/net/ethernet | |
| parent | nfp: add offloads on representors (diff) | |
| download | linux-dev-9571d9877546434682b653e8a81a5a177cd4529e.tar.xz linux-dev-9571d9877546434682b653e8a81a5a177cd4529e.zip | |
nfp: add offset to all TLV parsing errors
When troubleshooting incorrect FW capabilities it's useful to know
where the faulty TLV is located. Add offset to all errors messages.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c index d26ea32df8d9..6d5213b5bcb0 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c @@ -41,8 +41,8 @@ int nfp_net_tlv_caps_parse(struct device *dev, u8 __iomem *ctrl_mem, data += 4; if (length % NFP_NET_CFG_TLV_LENGTH_INC) { - dev_err(dev, "TLV size not multiple of %u len:%u\n", - NFP_NET_CFG_TLV_LENGTH_INC, length); + dev_err(dev, "TLV size not multiple of %u offset:%u len:%u\n", + NFP_NET_CFG_TLV_LENGTH_INC, offset, length); return -EINVAL; } if (data + length > end) { @@ -61,14 +61,14 @@ int nfp_net_tlv_caps_parse(struct device *dev, u8 __iomem *ctrl_mem, if (!length) return 0; - dev_err(dev, "END TLV should be empty, has len:%d\n", - length); + dev_err(dev, "END TLV should be empty, has offset:%u len:%d\n", + offset, length); return -EINVAL; case NFP_NET_CFG_TLV_TYPE_ME_FREQ: if (length != 4) { dev_err(dev, - "ME FREQ TLV should be 4B, is %dB\n", - length); + "ME FREQ TLV should be 4B, is %dB offset:%u\n", + length, offset); return -EINVAL; } @@ -92,8 +92,8 @@ int nfp_net_tlv_caps_parse(struct device *dev, u8 __iomem *ctrl_mem, break; case NFP_NET_CFG_TLV_TYPE_REPR_CAP: if (length < 4) { - dev_err(dev, "REPR CAP TLV short %dB < 4B\n", - length); + dev_err(dev, "REPR CAP TLV short %dB < 4B offset:%u\n", + length, offset); return -EINVAL; } |