diff options
| author |   Denis Bolotin <denis.bolotin@cavium.com> | 2018-11-12 12:50:23 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-11-13 08:51:16 -0800 |
| commit | ed4eac20dcffdad47709422e0cb925981b056668 (patch) | |
| tree | ce81e5d3461aa2787da43b95ff35b91b8b63f74c /drivers/net/ethernet | |
| parent | qed: Fix rdma_info structure allocation (diff) | |
| download | linux-dev-ed4eac20dcffdad47709422e0cb925981b056668.tar.xz linux-dev-ed4eac20dcffdad47709422e0cb925981b056668.zip | |
qed: Fix reading wrong value in loop condition
The value of "sb_index" is written by the hardware. Reading its value and
writing it to "index" must finish before checking the loop condition.
Signed-off-by: Denis Bolotin <denis.bolotin@cavium.com>
Signed-off-by: Michal Kalderon <michal.kalderon@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_int.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c index 0f0aba793352..b22f464ea3fa 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_int.c +++ b/drivers/net/ethernet/qlogic/qed/qed_int.c @@ -992,6 +992,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn) */ do { index = p_sb_attn->sb_index; + /* finish reading index before the loop condition */ + dma_rmb(); attn_bits = le32_to_cpu(p_sb_attn->atten_bits); attn_acks = le32_to_cpu(p_sb_attn->atten_ack); } while (index != p_sb_attn->sb_index); |