diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2018-06-07 17:54:37 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-06-08 18:45:52 -0400 |
| commit | 58d813afbe89658a5972747460a5fe19dec4dbcb (patch) | |
| tree | 9614bdc96e295f702b90d22ac9a1f53a804b5135 /drivers/net/fddi | |
| parent | net: stmmac: fix build failure due to missing COMMON_CLK dependency (diff) | |
| download | linux-dev-58d813afbe89658a5972747460a5fe19dec4dbcb.tar.xz linux-dev-58d813afbe89658a5972747460a5fe19dec4dbcb.zip | |
net: aquantia: fix unsigned numvecs comparison with less than zero
From: Colin Ian King <colin.king@canonical.com>
This was originally mistakenly submitted to net-next. Resubmitting to net.
The comparison of numvecs < 0 is always false because numvecs is a u32
and hence the error return from a failed call to pci_alloc_irq_vectores
is never detected. Fix this by using the signed int ret to handle the
error return and assign numvecs to err.
Detected by CoverityScan, CID#1468650 ("Unsigned compared against 0")
Fixes: a09bd81b5413 ("net: aquantia: Limit number of vectors to actually allocated irqs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/fddi')
0 files changed, 0 insertions, 0 deletions