diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2016-04-19 17:30:56 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-04-21 14:08:00 -0400 |
| commit | 1ba64facae5739d91884f8f34f25fef1cb66d930 (patch) | |
| tree | 6750e9a93dabd8548661980068117e8ebc460038 /drivers/net/geneve.c | |
| parent | NLA_BINARY misuse bug in HSR (diff) | |
| download | linux-dev-1ba64facae5739d91884f8f34f25fef1cb66d930.tar.xz linux-dev-1ba64facae5739d91884f8f34f25fef1cb66d930.zip | |
geneve: testing the wrong variable in geneve6_build_skb()
We intended to test "err" and not "skb".
Fixes: aed069df099c ('ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alexander Duyck <aduyck@mirantis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/geneve.c')
| -rw-r--r-- | drivers/net/geneve.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index efbc7ceedc3a..512dbe013713 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -733,7 +733,7 @@ static int geneve6_build_skb(struct dst_entry *dst, struct sk_buff *skb, goto free_dst; err = udp_tunnel_handle_offloads(skb, udp_sum); - if (IS_ERR(skb)) + if (err) goto free_dst; gnvh = (struct genevehdr *)__skb_push(skb, sizeof(*gnvh) + opt_len); |