diff options
| author |   Julia Lawall <julia@diku.dk> | 2009-01-09 10:23:09 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-01-11 00:06:34 -0800 |
| commit | 0397a2648434a65d73564216c4f96945c192ad4a (patch) | |
| tree | 757101f05c64d68e4133f79b8989a61e35f55b73 /drivers/net/hamradio/6pack.c | |
| parent | drivers/isdn/hardware/mISDN: move a dereference below a NULL test (diff) | |
| download | linux-dev-0397a2648434a65d73564216c4f96945c192ad4a.tar.xz linux-dev-0397a2648434a65d73564216c4f96945c192ad4a.zip | |
drivers/net/hamradio/6pack.c: move a dereference below a NULL test
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hamradio/6pack.c')
| -rw-r--r-- | drivers/net/hamradio/6pack.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index 50f1e172ee8f..2d4089894ec7 100644 --- a/drivers/net/hamradio/6pack.c +++ b/drivers/net/hamradio/6pack.c @@ -717,11 +717,12 @@ static int sixpack_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg) { struct sixpack *sp = sp_get(tty); - struct net_device *dev = sp->dev; + struct net_device *dev; unsigned int tmp, err; if (!sp) return -ENXIO; + dev = sp->dev; switch(cmd) { case SIOCGIFNAME: |