aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/hamradio/hdlcdrv.c
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2019-08-21 21:48:46 +0200
committerDavid S. Miller <davem@davemloft.net>2019-08-22 16:22:03 -0700
commitb7deac31979bd09c69e0e6e064609fad55df35be (patch)
treefe8485ecbc691daec727b18ba4d7f8b3b5b0f209 /drivers/net/hamradio/hdlcdrv.c
parentcan: Delete unnecessary checks before the macro call “dev_kfree_skb” (diff)
downloadlinux-dev-b7deac31979bd09c69e0e6e064609fad55df35be.tar.xz
linux-dev-b7deac31979bd09c69e0e6e064609fad55df35be.zip
hamradio: Delete unnecessary checks before the macro call “dev_kfree_skb”
The dev_kfree_skb() function performs also input parameter validation. Thus the test around the shown calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hamradio/hdlcdrv.c')
-rw-r--r--drivers/net/hamradio/hdlcdrv.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c
index c6f83e0df0a3..df495b5595f5 100644
--- a/drivers/net/hamradio/hdlcdrv.c
+++ b/drivers/net/hamradio/hdlcdrv.c
@@ -475,8 +475,7 @@ static int hdlcdrv_close(struct net_device *dev)
if (s->ops && s->ops->close)
i = s->ops->close(dev);
- if (s->skb)
- dev_kfree_skb(s->skb);
+ dev_kfree_skb(s->skb);
s->skb = NULL;
s->opened = 0;
return i;