diff options
| author |   Andrea Parri (Microsoft) <parri.andrea@gmail.com> | 2020-11-18 16:33:10 +0100 |
|---|---|---|
| committer |   Wei Liu <wei.liu@kernel.org> | 2020-11-24 16:22:10 +0000 |
| commit | 206ad34d52a2f1205c84d08c12fc116aad0eb407 (patch) | |
| tree | 8f5c34c75298a5132f8ca86d1133391d2d0ba2b3 /drivers/net/hyperv | |
| parent | drivers: hv: vmbus: Fix call msleep using < 20ms (diff) | |
| download | linux-dev-206ad34d52a2f1205c84d08c12fc116aad0eb407.tar.xz linux-dev-206ad34d52a2f1205c84d08c12fc116aad0eb407.zip | |
hv_netvsc: Validate number of allocated sub-channels
Lack of validation could lead to out-of-bound reads and information
leaks (cf. usage of nvdev->chan_table[]). Check that the number of
allocated sub-channels fits into the expected range.
Suggested-by: Saruhan Karademir <skarade@microsoft.com>
Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Link: https://lore.kernel.org/r/20201118153310.112404-1-parri.andrea@gmail.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Diffstat (limited to 'drivers/net/hyperv')
| -rw-r--r-- | drivers/net/hyperv/rndis_filter.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 6ae43319ece6..9a51fa3003a8 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -1224,6 +1224,11 @@ int rndis_set_subchannel(struct net_device *ndev, return -EIO; } + /* Check that number of allocated sub channel is within the expected range */ + if (init_packet->msg.v5_msg.subchn_comp.num_subchannels > nvdev->num_chn - 1) { + netdev_err(ndev, "invalid number of allocated sub channel\n"); + return -EINVAL; + } nvdev->num_chn = 1 + init_packet->msg.v5_msg.subchn_comp.num_subchannels; |