diff options
| author |   Stephen Hemminger <stephen@networkplumber.org> | 2018-03-02 13:49:05 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-04 22:18:20 -0500 |
| commit | d64e38ae690e3337db0d38d9b149a193a1646c4b (patch) | |
| tree | 0aba67f10cda81d2040138605e0be56f2472ac79 /drivers/net/hyperv | |
| parent | hv_netvsc: cancel subchannel setup before halting device (diff) | |
| download | linux-dev-d64e38ae690e3337db0d38d9b149a193a1646c4b.tar.xz linux-dev-d64e38ae690e3337db0d38d9b149a193a1646c4b.zip | |
hv_netvsc: fix race in napi poll when rescheduling
There is a race between napi_reschedule and re-enabling interrupts
which could lead to missed host interrrupts. This occurs when
interrupts are re-enabled (hv_end_read) and vmbus irq callback
(netvsc_channel_cb) has already scheduled NAPI.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hyperv')
| -rw-r--r-- | drivers/net/hyperv/netvsc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index ff97a85b2e9d..4237cedc4f08 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c @@ -1207,9 +1207,10 @@ int netvsc_poll(struct napi_struct *napi, int budget) if (send_recv_completions(ndev, net_device, nvchan) == 0 && work_done < budget && napi_complete_done(napi, work_done) && - hv_end_read(&channel->inbound)) { + hv_end_read(&channel->inbound) && + napi_schedule_prep(napi)) { hv_begin_read(&channel->inbound); - napi_reschedule(napi); + __napi_schedule(napi); } /* Driver may overshoot since multiple packets per descriptor */ |