diff options
| author |   YueHaibing <yuehaibing@huawei.com> | 2018-12-11 11:13:39 +0800 |
|---|---|---|
| committer |   Stefan Schmidt <stefan@datenfreihafen.org> | 2018-12-11 09:33:11 +0100 |
| commit | 8e41cae64b08fe2e86a9ffb88b295c6b4b3a3322 (patch) | |
| tree | 52fc3aa2eef82e742e3d8ed491a9ee3744c173f7 /drivers/net/ieee802154 | |
| parent | ieee802154: hwsim: fix off-by-one in parse nested (diff) | |
| download | linux-dev-8e41cae64b08fe2e86a9ffb88b295c6b4b3a3322.tar.xz linux-dev-8e41cae64b08fe2e86a9ffb88b295c6b4b3a3322.zip | |
ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done
gcc warning this:
drivers/net/ieee802154/ca8210.c:730:10: warning:
comparison is always false due to limited range of data type [-Wtype-limits]
'len' is u8 type, we get it from buf[1] adding 2, which can overflow.
This patch change the type of 'len' to unsigned int to avoid this,also fix
the gcc warning.
Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'drivers/net/ieee802154')
| -rw-r--r-- | drivers/net/ieee802154/ca8210.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 0ff5a403a8dc..b2ff903a9cb6 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -721,7 +721,7 @@ static void ca8210_mlme_reset_worker(struct work_struct *work) static void ca8210_rx_done(struct cas_control *cas_ctl) { u8 *buf; - u8 len; + unsigned int len; struct work_priv_container *mlme_reset_wpc; struct ca8210_priv *priv = cas_ctl->priv; @@ -730,7 +730,7 @@ static void ca8210_rx_done(struct cas_control *cas_ctl) if (len > CA8210_SPI_BUF_SIZE) { dev_crit( &priv->spi->dev, - "Received packet len (%d) erroneously long\n", + "Received packet len (%u) erroneously long\n", len ); goto finish; |