diff options
| author |   Alex Elder <elder@linaro.org> | 2021-07-26 12:40:10 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-07-26 22:38:11 +0100 |
| commit | 5bc5588466a1f8b48fb04f56c46474a30508a3d6 (patch) | |
| tree | 7322b4bc3dcab81b14a86b0a56bc8503b1449d13 /drivers/net/ipa/ipa_table.c | |
| parent | net: ipa: kill the remaining conditional validation code (diff) | |
| download | linux-dev-5bc5588466a1f8b48fb04f56c46474a30508a3d6.tar.xz linux-dev-5bc5588466a1f8b48fb04f56c46474a30508a3d6.zip | |
net: ipa: use WARN_ON() rather than assertions
I've added commented assertions to record certain properties that
can be assumed to hold in certain places in the IPA code. Convert
these into real WARN_ON() calls so the assertions are actually
checked, using the standard WARN_ON() mechanism.
Where errors can be returned, return an error if a warning is
triggered.
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ipa/ipa_table.c')
| -rw-r--r-- | drivers/net/ipa/ipa_table.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c index c607ebec7456..2324e1b93e37 100644 --- a/drivers/net/ipa/ipa_table.c +++ b/drivers/net/ipa/ipa_table.c @@ -231,7 +231,7 @@ static dma_addr_t ipa_table_addr(struct ipa *ipa, bool filter_mask, u16 count) if (!count) return 0; -/* assert(count <= max_t(u32, IPA_FILTER_COUNT_MAX, IPA_ROUTE_COUNT_MAX)); */ + WARN_ON(count > max_t(u32, IPA_FILTER_COUNT_MAX, IPA_ROUTE_COUNT_MAX)); /* Skip over the zero rule and possibly the filter mask */ skip = filter_mask ? 1 : 2; |