diff options
| author |   Wang Chen <wangchen@cn.fujitsu.com> | 2008-07-22 13:13:12 +0800 |
|---|---|---|
| committer |   Jeff Garzik <jgarzik@redhat.com> | 2008-08-07 02:23:19 -0400 |
| commit | c16d118537cadb21d186e35aebad90a13cd78846 (patch) | |
| tree | 8fc1ab697f2476ecd2b39522efcf6234be3dc5c0 /drivers/net/ni5010.c | |
| parent | dm9000: Support MAC address setting through platform data. (diff) | |
| download | linux-dev-c16d118537cadb21d186e35aebad90a13cd78846.tar.xz linux-dev-c16d118537cadb21d186e35aebad90a13cd78846.zip | |
[netdrvr] Drivers should not set IFF_* flag themselves
Some hardware set promisc when they are requested to set IFF_ALLMULTI flag.
It's ok, but if drivers set IFF_PROMISC flag when they set promisc,
it will broken upper layer handle for promisc and allmulti.
In addition, drivers can use their own hardware programming to make it.
So do not allow drivers to set IFF_* flags.
This is a general driver fix, so I didn't split it to pieces and send
to specific driver maintainers.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/ni5010.c')
| -rw-r--r-- | drivers/net/ni5010.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ni5010.c b/drivers/net/ni5010.c index a20005c09e07..8e0ca9f4e404 100644 --- a/drivers/net/ni5010.c +++ b/drivers/net/ni5010.c @@ -648,7 +648,6 @@ static void ni5010_set_multicast_list(struct net_device *dev) PRINTK2((KERN_DEBUG "%s: entering set_multicast_list\n", dev->name)); if (dev->flags&IFF_PROMISC || dev->flags&IFF_ALLMULTI || dev->mc_list) { - dev->flags |= IFF_PROMISC; outb(RMD_PROMISC, EDLC_RMODE); /* Enable promiscuous mode */ PRINTK((KERN_DEBUG "%s: Entering promiscuous mode\n", dev->name)); } else { |