diff options
| author |   Olof Johansson <olof@lixom.net> | 2007-11-28 20:58:06 -0600 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2008-01-28 15:04:26 -0800 |
| commit | 8304b633c5e8c9ba34d3cc7f24f52434d3a3b93b (patch) | |
| tree | 86bcca546f669fed53b759163d5831aa371099fd /drivers/net/pasemi_mac.c | |
| parent | pasemi_mac: Remove SKB copy/recycle logic (diff) | |
| download | linux-dev-8304b633c5e8c9ba34d3cc7f24f52434d3a3b93b.tar.xz linux-dev-8304b633c5e8c9ba34d3cc7f24f52434d3a3b93b.zip | |
pasemi_mac: Print warning when not attaching to a PHY
pasemi_mac: Print warning when not attaching to a PHY
Print a warning on the console when not connecting to a phy for an interface.
It turns out to be a pretty common problem when someone gets the MDIO info
wrong in their device tree, resulting in the macs running at a fixed 1Gbit FD.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/pasemi_mac.c')
| -rw-r--r-- | drivers/net/pasemi_mac.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index 07475bb7d860..7345a81bb2c6 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pasemi_mac.c @@ -1064,11 +1064,12 @@ static int pasemi_mac_open(struct net_device *dev) write_mac_reg(mac, PAS_MAC_CFG_PCFG, flags); ret = pasemi_mac_phy_init(dev); - /* Some configs don't have PHYs (XAUI etc), so don't complain about - * failed init due to -ENODEV. + /* Warn for missing PHY on SGMII (1Gig) ports. */ - if (ret && ret != -ENODEV) - dev_warn(&mac->pdev->dev, "phy init failed: %d\n", ret); + if (ret && mac->type == MAC_TYPE_GMAC) { + dev_warn(&mac->pdev->dev, "PHY init failed: %d.\n", ret); + dev_warn(&mac->pdev->dev, "Defaulting to 1Gbit full duplex\n"); + } netif_start_queue(dev); napi_enable(&mac->napi); |