diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-06-28 21:12:59 +0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-06-29 20:57:15 -0700 |
| commit | dbc6fc7e3f76ac8a584cd39f9978d6b41a96e75a (patch) | |
| tree | 3169d5a5a73624f5fd0ffac6a8d7931443363b9a /drivers/net/pcs | |
| parent | net: dsa: rzn1-a5psw: fix a NULL vs IS_ERR() check in a5psw_probe() (diff) | |
| download | linux-dev-dbc6fc7e3f76ac8a584cd39f9978d6b41a96e75a.tar.xz linux-dev-dbc6fc7e3f76ac8a584cd39f9978d6b41a96e75a.zip | |
net: pcs-rzn1-miic: fix return value check in miic_probe()
On failure, devm_platform_ioremap_resource() returns a ERR_PTR() value
and not NULL. Fix return value checking by using IS_ERR() and return
PTR_ERR() as error value.
Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Clément Léger <clement.leger@bootlin.com>
Link: https://lore.kernel.org/r/20220628131259.3109124-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/pcs')
| -rw-r--r-- | drivers/net/pcs/pcs-rzn1-miic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c index 8f5e910f443d..d896961e48cc 100644 --- a/drivers/net/pcs/pcs-rzn1-miic.c +++ b/drivers/net/pcs/pcs-rzn1-miic.c @@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev) spin_lock_init(&miic->lock); miic->dev = dev; miic->base = devm_platform_ioremap_resource(pdev, 0); - if (!miic->base) - return -EINVAL; + if (IS_ERR(miic->base)) + return PTR_ERR(miic->base); ret = devm_pm_runtime_enable(dev); if (ret < 0) |