diff options
| author |   Max Uvarov <muvarov@gmail.com> | 2019-05-28 13:00:52 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-05-29 14:28:48 -0700 |
| commit | 2b892649254fec01678c64f16427622b41fa27f4 (patch) | |
| tree | 87d27da5f976b195fcb5e62fbe6d1b37a72c0ee0 /drivers/net/phy/dp83867.c | |
| parent | net: phy: dp83867: do not call config_init twice (diff) | |
| download | linux-dev-2b892649254fec01678c64f16427622b41fa27f4.tar.xz linux-dev-2b892649254fec01678c64f16427622b41fa27f4.zip | |
net: phy: dp83867: Set up RGMII TX delay
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.
Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy")
Signed-off-by: Max Uvarov <muvarov@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/dp83867.c')
| -rw-r--r-- | drivers/net/phy/dp83867.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 1ec48ecf4133..c71c7d0f53f0 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -255,10 +255,8 @@ static int dp83867_config_init(struct phy_device *phydev) ret = phy_write(phydev, MII_DP83867_PHYCTRL, val); if (ret) return ret; - } - if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) && - (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) { + /* Set up RGMII delays */ val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL); if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) |