aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/phy/dp83tc811.c
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2019-08-17 12:29:25 +0200
committerDavid S. Miller <davem@davemloft.net>2019-08-17 12:34:50 -0700
commitc227ce4423855bddb41a05ad25a93f13b96c89bd (patch)
tree7a946bfaf68a1006c41507726a679e37b183cfc1 /drivers/net/phy/dp83tc811.c
parentipvlan: set hw_enc_features like macvlan (diff)
downloadlinux-dev-c227ce4423855bddb41a05ad25a93f13b96c89bd.tar.xz
linux-dev-c227ce4423855bddb41a05ad25a93f13b96c89bd.zip
net: phy: remove calls to genphy_config_init
Supported PHY features are either auto-detected or explicitly set. In both cases calling genphy_config_init isn't needed. All that genphy_config_init does is removing features that are set as supported but can't be auto-detected. Basically it duplicates the code in genphy_read_abilities. Therefore remove such calls from all PHY drivers. v2: - remove call also from new adin PHY driver v3: - pass NULL as config_init function pointer for dp83848 Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/dp83tc811.c')
-rw-r--r--drivers/net/phy/dp83tc811.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index ac27da16824d..06f08832ebcd 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -277,10 +277,6 @@ static int dp83811_config_init(struct phy_device *phydev)
{
int value, err;
- err = genphy_config_init(phydev);
- if (err < 0)
- return err;
-
value = phy_read(phydev, MII_DP83811_SGMII_CTRL);
if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {
err = phy_write(phydev, MII_DP83811_SGMII_CTRL,