diff options
| author |   Andrew Lunn <andrew@lunn.ch> | 2018-09-29 23:04:10 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-10-01 22:55:35 -0700 |
| commit | ab2a605fa621ecf4ec26603a237822f7772cfa28 (patch) | |
| tree | 7dc31f40374d00acf6c2e232c26cbdfd14dfa9c3 /drivers/net/phy/marvell10g.c | |
| parent | net: phy: Move linkmode helpers to somewhere public (diff) | |
| download | linux-dev-ab2a605fa621ecf4ec26603a237822f7772cfa28.tar.xz linux-dev-ab2a605fa621ecf4ec26603a237822f7772cfa28.zip | |
net: phy: Add phydev_warn()
Not all new style LINK_MODE bits can be converted into old style
SUPPORTED bits. We need to warn when such a conversion is attempted.
Add a helper for this.
Convert all pr_warn() calls to phydev_warn() where possible.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/marvell10g.c')
| -rw-r--r-- | drivers/net/phy/marvell10g.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c index f77a2d9e7f9d..f214834819dd 100644 --- a/drivers/net/phy/marvell10g.c +++ b/drivers/net/phy/marvell10g.c @@ -337,9 +337,9 @@ static int mv3310_config_init(struct phy_device *phydev) } if (!ethtool_convert_link_mode_to_legacy_u32(&mask, supported)) - dev_warn(&phydev->mdio.dev, - "PHY supports (%*pb) more modes than phylib supports, some modes not supported.\n", - __ETHTOOL_LINK_MODE_MASK_NBITS, supported); + phydev_warn(phydev, + "PHY supports (%*pb) more modes than phylib supports, some modes not supported.\n", + __ETHTOOL_LINK_MODE_MASK_NBITS, supported); phydev->supported &= mask; phydev->advertising &= phydev->supported; |